[
https://issues.apache.org/jira/browse/MINIFICPP-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239227#comment-16239227
]
ASF GitHub Bot commented on MINIFICPP-46:
-----------------------------------------
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/178
MINIFI-291 Added standard Lua packages to scripting environment
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-291
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #178
----
commit 9395db968318ae7ace2bc5e12721cbcd0f1cecf3
Author: Andrew I. Christianson <[email protected]>
Date: 2017-11-04T20:54:58Z
MINIFI-291 Added standard Lua packages to scripting environment
----
> Convert StreamFactory to a controller service
> ---------------------------------------------
>
> Key: MINIFICPP-46
> URL: https://issues.apache.org/jira/browse/MINIFICPP-46
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: marco polo
> Priority: Major
>
> Once https://github.com/apache/nifi-minifi-cpp/pull/83/files is merged, we
> can create more controller services. We can move the socket factory over to a
> controller service which will allow us to better control socket
> creation/reuse. Possibilities include limiting the number of sockets created,
> what happens when that max is reached, more easily link services so that
> secure sockets are created without the need for a static configuration in
> minifi.properies
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
