[
https://issues.apache.org/jira/browse/NIFI-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240497#comment-16240497
]
ASF GitHub Bot commented on NIFI-4198:
--------------------------------------
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2094#discussion_r149124819
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractElasticsearchHttpProcessor.java
---
@@ -97,6 +116,27 @@
private final AtomicReference<OkHttpClient>
okHttpClientAtomicReference = new AtomicReference<>();
+ private static final List<PropertyDescriptor> propertyDescriptors;
+
+ static {
+ final List<PropertyDescriptor> properties = new ArrayList<>();
+ properties.add(ES_URL);
--- End diff --
Won't some of these be added twice, once by this abstract class and once by
the individual processor? I like the idea of adding all common ones here, but I
think they need to be removed from Fetch/PutESHttp
> *ElasticsearchHttp processors do not expose Proxy settings
> ----------------------------------------------------------
>
> Key: NIFI-4198
> URL: https://issues.apache.org/jira/browse/NIFI-4198
> Project: Apache NiFi
> Issue Type: Improvement
> Affects Versions: 1.4.0
> Reporter: Andre F de Miranda
> Assignee: Arun Manivannan
> Attachments: NIFI-4198-ElasticProxy-TestFixtures.pdf,
> NIFI-4198-ElasticProxy.xml
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
