[
https://issues.apache.org/jira/browse/NIFIREG-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247590#comment-16247590
]
ASF GitHub Bot commented on NIFIREG-51:
---------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi-registry/pull/36
NIFIREG-51: Fixed comparison between empty collection vs null and add…
…ed notion of a DifferenceDescriptor to allow different verbiage for flow
differences
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi-registry NIFIREG-51
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-registry/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit d273ab804d0c05677d3bc18f179ecd86ddb2e5cc
Author: Mark Payne <[email protected]>
Date: 2017-11-10T14:40:29Z
NIFIREG-51: Fixed comparison between empty collection vs null and added
notion of a DifferenceDescriptor to allow different verbiage for flow
differences
----
> Flow diff is wrong when comparing a nifi flow to versioned flow because off
> empty collection vs null
> ----------------------------------------------------------------------------------------------------
>
> Key: NIFIREG-51
> URL: https://issues.apache.org/jira/browse/NIFIREG-51
> Project: NiFi Registry
> Issue Type: Bug
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 0.0.1
>
>
> When comparing a NiFi Flow to what is in the Flow Registry, the flow diff
> indicates many things are different because when comes back from the registry
> may have a null value for collections that have nothing in them, but NiFi
> always generates an empty collection. When performing a diff, those should be
> the same.
> Also, we should have ability to change verbiage when comparing two different
> flows because sometimes we want to compare them as potentially disparate
> flows while other times we want to compare them as two versions of the same
> flow.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
