Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/181
This looks great. My only critique is that FilesystemUtils is used in a
stateful way (presumably just to keep a cache of previous unique files?) I
think keeping it entirely stateless would be preferable. Looking at the same
issue, keeping a stateful instance of "utilities" isn't very meaningful. If
part of it really needs to be stateful, I would consider making a nested class
in FilesystemUtils i.e. FilesystemUtils::UniqueFileGenerator.
Overall the change is great and removes a huge dependency without adding a
lot of complexity.
---
