[
https://issues.apache.org/jira/browse/MINIFICPP-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247685#comment-16247685
]
ASF GitHub Bot commented on MINIFICPP-297:
------------------------------------------
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/181
This looks great. My only critique is that FilesystemUtils is used in a
stateful way (presumably just to keep a cache of previous unique files?) I
think keeping it entirely stateless would be preferable. Looking at the same
issue, keeping a stateful instance of "utilities" isn't very meaningful. If
part of it really needs to be stateful, I would consider making a nested class
in FilesystemUtils i.e. FilesystemUtils::UniqueFileGenerator.
Overall the change is great and removes a huge dependency without adding a
lot of complexity.
> Remove Boost as a dependency for archive extensions
> ---------------------------------------------------
>
> Key: MINIFICPP-297
> URL: https://issues.apache.org/jira/browse/MINIFICPP-297
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: marco polo
> Assignee: marco polo
> Fix For: 0.3.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
