[ 
https://issues.apache.org/jira/browse/NIFI-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247853#comment-16247853
 ] 

ASF GitHub Bot commented on NIFI-4371:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2138#discussion_r150299869
  
    --- Diff: 
nifi-mock/src/main/java/org/apache/nifi/util/MockPropertyValue.java ---
    @@ -225,7 +225,7 @@ public String toString() {
     
         @Override
         public boolean isExpressionLanguagePresent() {
    -        if (!expectExpressions) {
    +        if (expectExpressions == null || !expectExpressions) {
    --- End diff --
    
    This fix (in whatever form it takes) should be as part of 
[NIFI-4590](https://issues.apache.org/jira/browse/NIFI-4590). As a temporary 
fix in my own PR #2260 , I put a try/catch around isExpressionLanguagePresent() 
with a comment about NIFI-4590. You don't have to do that specifically, but if 
you can get around changing the mock stuff in this PR, I can merge and add a 
reference to your workaround in NIFI-4590, to ask that your workaround be 
removed as part of that Jira.


> Add support for query timeout in Hive processors
> ------------------------------------------------
>
>                 Key: NIFI-4371
>                 URL: https://issues.apache.org/jira/browse/NIFI-4371
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>         Attachments: Screen Shot 2017-09-09 at 4.31.21 PM.png, Screen Shot 
> 2017-09-09 at 6.38.51 PM.png, Screen Shot 2017-09-09 at 6.40.48 PM.png
>
>
> With HIVE-4924 it is possible to set a query timeout when executing a query 
> against Hive (starting with Hive 2.1). Right now, NiFi is built using Hive 
> 1.2.1 and this feature is not available by default (the method is not 
> implemented in the driver). However, if building NiFi with specific profiles 
> this feature can be used.
> The objective is to expose the query timeout parameter in the processor and 
> enable expression language. If the version of the driver is not implementing 
> the query timeout the processor will be in invalid state (unless expression 
> language is used, and in this case, the flow file will be routed to the 
> failure relationship).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to