[
https://issues.apache.org/jira/browse/NIFI-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250027#comment-16250027
]
ASF GitHub Bot commented on NIFI-4598:
--------------------------------------
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2270#discussion_r150637299
--- Diff:
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/CachingRemoteGroupContentsManager.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.remote.client;
+
+import java.io.IOException;
+import java.io.Serializable;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
+
+import org.apache.nifi.remote.util.SiteToSiteRestApiClient;
+import org.apache.nifi.web.api.dto.ControllerDTO;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class CachingRemoteGroupContentsManager implements
RemoteGroupContentsManager {
--- End diff --
D'oh! Right you are. Started implementing it in a separate class, then
realized that it worked a lot more nicely to just embed the logic in the client
and forgot to remove the interface & impl. Will push another commit.
> Multiple Remote Process Groups pointing to the same URL each are constantly
> making HTTP Requests to the destination URL
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-4598
> URL: https://issues.apache.org/jira/browse/NIFI-4598
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.5.0
>
>
> If I have 10 RPG's pointing to localhost:8080/nifi then I have 10 RPG's
> making the same HTTP Requests to get cluster info. This can quickly leave to
> having too many simultaneously requests according to the
> ThreadPoolRequestReplicator.
> We should be smarter about the caching of the information so that multiple
> RPG's with the same URL can share this information instead of constantly
> requesting it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
