Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/182#discussion_r150577123
  
    --- Diff: CMakeLists.txt ---
    @@ -143,21 +143,38 @@ if (ENABLE_GPS)
        createExtension(GPS-EXTENSION "GPS EXTENSIONS" "Enables LibGPS 
Functionality and the GetGPS processor." "extensions/gps" 
"${TEST_DIR}/gps-tests")
     endif(ENABLE_GPS)
     
    +## Create LibRdKafka Extension
    +if ( NOT LibRdKafka_FOUND OR BUILD_LIBRDKAFKA)
    +   set(BUILD_TP "TRUE")
    +endif()
    +option(DISABLE_LIBRDKAFKA "Disables the librdkafka extensions." OFF)
    +if (NOT DISABLE_LIBRDKAFKA)
    --- End diff --
    
    Can this be ENABLE_KAFKA so that it's a feature to select and not eliminate?


---

Reply via email to