[ https://issues.apache.org/jira/browse/NIFI-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251985#comment-16251985 ]
ASF GitHub Bot commented on NIFI-4608: -------------------------------------- GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/2273 NIFI-4608 Fixed build errors Removed unnecessary NiFiProperties mocking given enhancements to StringEncryptor. Fixed checkstyle issues. Fixed test failure in FingerprintFactoryTest. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alopresto/nifi NIFI-4608 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2273.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2273 ---- commit 7d727bee912b473ffb3fd31fe4ac6c560e262d81 Author: Andy LoPresto <alopre...@apache.org> Date: 2017-11-14T18:36:35Z NIFI-4608 Removed unnecessary NiFiProperties mocking given enhancements to StringEncryptor. Fixed checkstyle issues. Fixed test failure in FingerprintFactoryTest. ---- > Fix build issues (checkstyle and test failures) > ----------------------------------------------- > > Key: NIFI-4608 > URL: https://issues.apache.org/jira/browse/NIFI-4608 > Project: Apache NiFi > Issue Type: Bug > Components: Tools and Build > Affects Versions: 1.4.0 > Reporter: Andy LoPresto > Assignee: Andy LoPresto > Labels: build, checkstyle, test-failure > > There are checkstyle issues in RemoteProcessGroupPortDTO.java and a test > failure in FingerprintFactoryTest.java. > {code} > [INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @ nifi-client-dto > --- > [WARNING] > src/main/java/org/apache/nifi/web/api/dto/RemoteProcessGroupPortDTO.java[83] > (regexp) RegexpSinglelineJava: Line has trailing whitespace. > [WARNING] > src/main/java/org/apache/nifi/web/api/dto/RemoteProcessGroupPortDTO.java[88] > (regexp) RegexpSinglelineJava: Line has trailing whitespace. > {code} > {code} > Results : > Failed tests: > FingerprintFactoryTest.testRemotePortFingerprint:317 > expected:<portId[]3true123464KB10sec> but > was:<portId[NO_VALUE]3true123464KB10sec> > Tests run: 318, Failures: 1, Errors: 0, Skipped: 11 > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)