[GitHub] nifi-minifi-cpp issue #185: MINIFICPP-303 Upgrade civetweb and rocksdb

[achristianson]

Github user achristianson commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/185
  
    I can build & make test this on CentOS 7.4 with devtoolset-6 (GCC 6.3.1), 
but it fails when using devtoolset-7 (GCC 7.1.1).
    
    ```
    In file included from 
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/write_batch_internal.h:12:0,
                     from 
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/column_family.h:20,
                     from 
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/version_set.h:31,
                     from 
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/compaction.h:11,
                     from 
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/compaction_iterator.h:12,
                     from 
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/builder.cc:16:
    
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/write_thread.h:
 In member function ‘std::mutex& 
rocksdb::WriteThread::Writer::StateMutex()’:
    
/home/achristianson/workspace/nifi-minifi-cpp/thirdparty/rocksdb/db/write_thread.h:225:78:
 error: dereferencing type-punned pointer will break strict-aliasing rules 
[-Werror=strict-aliasing]
           return 
*static_cast<std::mutex*>(static_cast<void*>(&state_mutex_bytes));
    ```
    
    I would still merge this because I wasn't able to build with devtoolset-7 
before this change, either. It's an improvement to have the newer versions, and 
I can't find any regressions.


---