[
https://issues.apache.org/jira/browse/NIFI-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252184#comment-16252184
]
Jeff Storck commented on NIFI-3366:
-----------------------------------
[~ggwizdz1] Thanks for your contribution! In doing an initial review of the
patch, I have a few questions/comments:
* In MoveHDFS#processBatchOfFiles, line 354, there's a for loop that tries 10
times to rename/move the file. Do the rename/copy attempts return false often
enough that the for loop is required? Have you investigated why those attempts
return false?
* Can you add a test for the copy operation, in addition to the existing test
for the move operation?
* PutHDFS properties for REMOTE_OWNER and REMOTE_GROUP both allow expression
language. Have you considered allowing that for the same properties in
MoveHDFS?
* There are three public static variables that appear to be unused, and should
be removed: "MAX_WORKING_QUEUE_SIZE", "BUFFER_SIZE_KEY", "BUFFER_SIZE_DEFAULT".
> MoveHDFS Processor
> ------------------
>
> Key: NIFI-3366
> URL: https://issues.apache.org/jira/browse/NIFI-3366
> Project: Apache NiFi
> Issue Type: New Feature
> Reporter: Joseph Niemiec
> Assignee: Gray Gwizdz
> Priority: Minor
> Attachments: 0001-MoveHDFS-Processor.patch,
> 0001-NIFI-3366-MoveHDFS-processor-supports-expressions-la.patch
>
>
> Today the PutHDFS Processor merely places a file into HDFS from NiFi. There
> are times when we may want to move Files/Directories around on HDFS as part
> of a workflow. This could be after the PutHDFS processor has placed the
> file, or from some other trigger.
> Initially we are targeting to take a flow file attribute of an absolute HDFS
> path, and be able to move it to a target HDFS Path using the Filesystem
> RENAME API.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
