Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2269
@yuri1969 the behavior of the code editor addition looks good! Changes made
between the Script Engine/Body properties stay in place as changes are made and
as you move between the standard/advanced editors. I did not experience
anything odd there.
I agree with others about how closing it should return to point from which
you came.
Regarding the save/close behavior - I would not expect 'SAVE' to close as
well. It is, however, not very intuitive to save then have to go up the the 'X'
button to close it out. Ideally I'd suggest an auto-save behavior that
continuously notifies the user their work has been saved after a certain amount
of time. Then place a close/done/ok button at the bottom right to close it out.
Alternatively, and probably easier, group a separate 'Save' button with the
code editor and add a close/done/ok button at the bottom right. There is more
of a natural flow that way, working from the top left to the bottom right of
the dialog.
Also, another idea, with the exception of Jolt these advanced UIs are
pretty simple in that you're only choosing a type (engine) then entering code
(body). It would be nice to simply have access the code editor directly from
the property list when you click the cell to edit the value. This would
eliminate the need for the advanced UI.
---
