[
https://issues.apache.org/jira/browse/NIFI-4400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257272#comment-16257272
]
ASF GitHub Bot commented on NIFI-4400:
--------------------------------------
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2269
To add to my previous comments, I also notice some styling changes, not
only in the advanced UI but other areas of the app as well. For example:
- Visible elements in the toolbar, status bar, and canvas palettes now have
a border-radius being applied; previously they had square corners (i.e., no
border-radius)
- Other areas such as shells and dialogs where the same canvas palette
style buttons appear are being affected as well (e.g., 'Open in New Window',
'Close', 'Refresh', etc.)
- Scott noted the fa-align icon sitting a pixel or two higher - I think
this is occurring on many other 'fa-...' icons. I notice shifted positions in
the canvas palette buttons, dialogs, and shells too
I would suggest that unless a new UI component is being introduced, we use
established styles to maintain a consistent look. From what I've seen I don't
believe there is a need to introduce anything new.
In the advanced UIs:
- the primary buttons (e.g., 'SAVE') have a border-radius now and also as
Scott noted some position shifting occurs on hover
- select/combo box styling is completely different, including the menu that
is shown when it is clicked on
- the 'Format' button should be square as are others that share the same
look
I would also suggest capitalizing 'ruby', 'lua', and 'python' --> Ruby,
Lua, Python
> Advanced UI with code editor for scripted processors
> ----------------------------------------------------
>
> Key: NIFI-4400
> URL: https://issues.apache.org/jira/browse/NIFI-4400
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI, Extensions
> Reporter: Pierre Villard
> Assignee: Yuri
>
> For the scripted processors it would nice to add an advanced UI with a "code
> editor mode" that would provide some very useful features when typing code:
> - indentation
> - code highlighting
> - do not close the window when hitting enter
> etc
> The use of codemirror.js (as already done for EL auto-completion) sounds like
> a good option.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
