[ https://issues.apache.org/jira/browse/NIFI-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261091#comment-16261091 ]
ASF GitHub Bot commented on NIFI-4625: -------------------------------------- Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2282 @otherview please update the PR to keep the previous formatting/whitespace so that your changes are more clear/obvious. Right now for a reviewer this looks like a pretty large changeset to go through. It is easier/faster of course if the changes are specific to your necessary functional change only. > Add External Versioning to PutElasticSearch5 Processor > ------------------------------------------------------ > > Key: NIFI-4625 > URL: https://issues.apache.org/jira/browse/NIFI-4625 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework > Affects Versions: 1.3.0 > Environment: All > Reporter: Pedro Gomes > Assignee: Pedro Gomes > Labels: elasticsearch, processor > Fix For: 1.5.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > Currently the PutElasticSearch5 processor does not support external > versioning. > The idea would be to add a property that follows the same logic as the Id > property, and allows index documents with an externally controlled version. > I've changed the code already and added some tests. Right now the changes > proposed are: > - Add a new property Version in the processor block. > - Change the Index operation to support the versioning number and versioning > type = external > - Check if the versioning is used with other operation types, fail if so. > (Idea behind this is that the bulk api doest not support external versioning > for any other operation except Index) -- This message was sent by Atlassian JIRA (v6.4.14#64029)