[
https://issues.apache.org/jira/browse/MINIFICPP-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261436#comment-16261436
]
ASF GitHub Bot commented on MINIFICPP-251:
------------------------------------------
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/203
MINIFICPP-251 Move Civet implementations to an extension.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NiFiLocal/nifi-minifi-cpp MINIFICPP-251
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/203.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #203
----
commit ae09003d288bf9a7fc9b9832574a17154f29ee9a
Author: Caleb Johnson <[email protected]>
Date: 2017-11-16T23:06:22Z
MINIFICPP-251 Move Civet implementations to an extension.
----
> Move Civet implementations to an extension.
> -------------------------------------------
>
> Key: MINIFICPP-251
> URL: https://issues.apache.org/jira/browse/MINIFICPP-251
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: marco polo
> Fix For: 0.4.0
>
>
> We should be able to move anything that uses Civet, such as ListenHTTP and
> any dependencies ( such as boost ) to an extension and allow boost, civet,
> and any related libraries to be excluded from the build with an argument
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
