[
https://issues.apache.org/jira/browse/NIFI-4583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261823#comment-16261823
]
ASF GitHub Bot commented on NIFI-4583:
--------------------------------------
GitHub user JohannesDaniel opened a pull request:
https://github.com/apache/nifi/pull/2285
NIFI-4583 Restructure nifi-solr-processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JohannesDaniel/nifi NIFI-4583
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2285.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2285
----
commit 9478079d1bbbec5109a01f1d50431d7f06111928
Author: U-WOODMARK\johannes.peter <[email protected]>
Date: 2017-11-21T15:38:18Z
NIFI-4583 Restructure nifi-solr-processors
----
> Restructure package nifi-solr-processors
> ----------------------------------------
>
> Key: NIFI-4583
> URL: https://issues.apache.org/jira/browse/NIFI-4583
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Johannes Peter
> Assignee: Johannes Peter
> Priority: Minor
>
> Several functionalities currently implemented e. g. in GetSolr or
> SolrProcessor should be made available for other processors or controller
> services. A class SolrUtils should be created containing several static
> methods. This includes the methods
> - getRequestParams (PutSolrContentStream)
> - solrDocumentsToRecordSet (GetSolr)
> - createSolrClient (SolrProcessor)
> and the inner class QueryResponseOutputStreamCallback (GetSolr)
> Some unit tests might be affected.
> The method declaration
> protected SolrClient createSolrClient(final ProcessContext context, final
> String solrLocation)
> should be changed to
> public static SolrClient createSolrClient(final PropertyContext context,
> final String solrLocation)
> to be suitable also for controller services.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
