[
https://issues.apache.org/jira/browse/NIFI-4632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262742#comment-16262742
]
ASF GitHub Bot commented on NIFI-4632:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2288
NIFI-4632: Add the local hostname to the list of validated host headers
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4632
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2288
----
commit 80ff1fe73b983ea380790ef8ae55d4cb10f0702b
Author: Mark Payne <[email protected]>
Date: 2017-11-22T14:56:09Z
NIFI-4632: Add the local hostname to the list of validated host headers
----
> Site-to-Site failing with default configuration
> -----------------------------------------------
>
> Key: NIFI-4632
> URL: https://issues.apache.org/jira/browse/NIFI-4632
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.5.0
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Critical
> Fix For: 1.5.0
>
>
> With a new install, from 'master' branch I created an Input Port and then a
> Remote Process Group pointing to localhost:8080/nifi. When attempting to send
> data to my Input Port, nothing appears to happen in the UI. In the logs, I
> see the following:
> {code}
> 2017-11-22 09:30:39,918 WARN [NiFi Web Server-184]
> o.a.nifi.web.server.HostHeaderHandler Request host header
> [<hostname>.local:8080] different from web hostname [localhost(:8080)].
> Overriding to [localhost:8080/nifi-api/site-to-site/peers]
> 2017-11-22 09:30:39,918 WARN [Http Site-to-Site PeerSelector]
> o.a.n.r.util.SiteToSiteRestApiClient Failed to parse Json. The specified URL
> http://<hostname>.local:8080/nifi-api is not a proper remote NiFi endpoint
> for Site-to-Site communication.
> requestedUrl=http://<hostname>.local:8080/nifi-api/site-to-site/peers,
> response=<h1>System Error</h1>
> <h2>The request contained an invalid host header [<hostname>.local:8080] in
> the request [/nifi-api/site-to-site/peers]. Check for request manipulation or
> third-party intercept. </h2>
> {code}
> I tried updating nifi.properties to set the "nifi.web.http.host" property to
> <hostname>.local and that did resolve the issue... but then I could not
> connect to the UI using localhost:8080 but instead had to connect using
> <hostname>.local.
> This appears to not affect any released versions of NiFi.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
