[
https://issues.apache.org/jira/browse/MINIFICPP-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263737#comment-16263737
]
ASF GitHub Bot commented on MINIFICPP-318:
------------------------------------------
GitHub user kevdoran opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/204
MINIFICPP-318 specify python2 as python interpreter for integration t…
…est virtualenv in docker-verify target
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevdoran/nifi-minifi-cpp MINIFICPP-318
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #204
----
commit 963bb8dc78eca0bb6c445afe174ba8cb3fc878f3
Author: Kevin Doran <[email protected]>
Date: 2017-11-23T03:12:22Z
MINIFICPP-318 specify python2 as python interpreter for integration test
virtualenv in docker-verify target
----
> Python virtualenv fails when virtualenv defaults to python3
> -----------------------------------------------------------
>
> Key: MINIFICPP-318
> URL: https://issues.apache.org/jira/browse/MINIFICPP-318
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Kevin Doran
> Assignee: Kevin Doran
> Priority: Minor
>
> In docker/DockerVerify.sh, the command that creates the Python virtualenv for
> running the integration tests does not specify the python executable to use.
> The tests require python2, so on a machine that virtualenv defaults to
> python3, the virtualenv does not work with the integration tests resulting in
> runtime errors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
