[
https://issues.apache.org/jira/browse/NIFI-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265866#comment-16265866
]
ASF GitHub Bot commented on NIFI-4193:
--------------------------------------
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2155#discussion_r153055354
--- Diff: nifi-docker/dockermaven/pom.xml ---
@@ -0,0 +1,82 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more
contributor
+ license agreements. See the NOTICE file distributed with this work for
additional
+ information regarding copyright ownership. The ASF licenses this file
to
+ You under the Apache License, Version 2.0 (the "License"); you may not
use
+ this file except in compliance with the License. You may obtain a copy
of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless
required
+ by applicable law or agreed to in writing, software distributed under
the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the
specific
+ language governing permissions and limitations under the License. -->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-docker</artifactId>
+ <version>1.4.0-SNAPSHOT</version>
--- End diff --
@apiri Hey, your ${project.version} change was just overlaid on top of
master so all the dockerfile-maven plugin changes are gone.
> Transition to Spotify dockerfile-maven plugin
> ---------------------------------------------
>
> Key: NIFI-4193
> URL: https://issues.apache.org/jira/browse/NIFI-4193
> Project: Apache NiFi
> Issue Type: Task
> Components: Docker
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
>
> As per
> https://github.com/spotify/docker-maven-plugin#the-future-of-docker-maven-plugin,
> it is preferred to make use of the dockerfile-maven plugin
> (https://github.com/spotify/dockerfile-maven). We should consider using this
> plugin instead as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
