[
https://issues.apache.org/jira/browse/NIFI-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266078#comment-16266078
]
ASF GitHub Bot commented on NIFI-4445:
--------------------------------------
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/2296
NIFI-4445 on fast machines the engine ran for 0 millis so the test ne…
…eds to allow this case
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-4445
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2296
----
commit db838f59e63fc6c649d599412aa13a6bd8ac1245
Author: joewitt <[email protected]>
Date: 2017-11-26T16:11:26Z
NIFI-4445 on fast machines the engine ran for 0 millis so the test needs to
allow this case
----
> Unit Test Failure for Scripted Reporting Task
> ---------------------------------------------
>
> Key: NIFI-4445
> URL: https://issues.apache.org/jira/browse/NIFI-4445
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.4.0
> Environment: Apache Maven 3.5.0
> (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T15:39:06-04:00)
> Maven home: /data1/apache-maven-3.5.0
> Java version: 1.8.0_144, vendor: Oracle Corporation
> Java home: /usr/java/jdk1.8.0_144/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.12.14-300.fc26.x86_64", arch: "amd64", family:
> "unix"
> Reporter: Joseph Witt
> Assignee: Matt Burgess
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.nifi.reporting.script.ScriptedReportingTaskGroovyTest
> Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.641 sec <<<
> FAILURE! - in org.apache.nifi.reporting.script.ScriptedReportingTaskGroovyTest
> testVMEventsGroovyScript(org.apache.nifi.reporting.script.ScriptedReportingTaskGroovyTest)
> Time elapsed: 0.024 sec <<< FAILURE!
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at org.junit.Assert$assertTrue$0.callStatic(Unknown Source)
> at
> org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallStatic(CallSiteArray.java:56)
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callStatic(AbstractCallSite.java:194)
> at
> org.codehaus.groovy.runtime.callsite.AbstractCallSite.callStatic(AbstractCallSite.java:206)
> at
> org.apache.nifi.reporting.script.ScriptedReportingTaskGroovyTest.testVMEventsGroovyScript(ScriptedReportingTaskGroovyTest.groovy:195)
> Appears to be related to the JDK/JRE. The same environment in terms of
> kernel/maven/etc... just slightly older JDK/JRE works perfectly fine.
> Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
> 2017-04-03T15:39:06-04:00)
> Maven home: /opt/apache-maven-3.5.0
> Java version: 1.8.0_141, vendor: Oracle Corporation
> Java home: /usr/java/jdk1.8.0_141/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.12.14-300.fc26.x86_64", arch: "amd64", family:
> "unix"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
