[
https://issues.apache.org/jira/browse/NIFI-4526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266880#comment-16266880
]
ASF GitHub Bot commented on NIFI-4526:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2298
NIFI-4526: Allow Target URI's of Remote Process Groups to be changed
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4526
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2298
----
commit 41b0c509d0e8122634d6e016a18a28e94cc83ed7
Author: Mark Payne <[email protected]>
Date: 2017-11-20T19:57:55Z
NIFI-4526: Allow Target URI's of Remote Process Groups to be changed
----
> The REST API and NiFi UI should allow the target URL for a remote process
> group to be edited
> --------------------------------------------------------------------------------------------
>
> Key: NIFI-4526
> URL: https://issues.apache.org/jira/browse/NIFI-4526
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework, Core UI, Flow Versioning
> Reporter: Joseph Witt
> Assignee: Mark Payne
> Priority: Critical
> Fix For: 1.5.0
>
>
> Today remote process groups (RPG) once established cannot have the target URL
> edited. If a user wants to change the URL they have to add a new RPG for the
> new target and change the relationships/connections to point to it. Then
> they can remove the old one.
> That process ensures that there is explicit (user provided mapping) to the
> new ports available at the new target. However, this is very limiting in
> templates today and would be very limiting to the effectiveness of the
> versioned flow registry and porting between environments.
> We could make the URL support expression language statements but at present
> that would be the first non component property (like processor properties)
> where EL is allowed and we need to have a more thoughtful and consistent
> approach for that to include things like number of processor threads/etc.. A
> cleaner and more consistent option is to do this like sensitive properties
> are being handled in versioned flows which is they are not part of the
> versioned flow definition but rather on import or when edited we allow the
> user to set their environment/flow specific values all without making the
> local flow version dirty in terms of versioned flow management.
> So, we should allow the user via the UI and obviously through REST API calls
> to change the URL. This would require stopping the RPG, changing the target
> URL (resycing/establishing remote ports/auth/etc..), then starting it. We
> need to make sure this change does not necessitate a new version of the flow.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
