Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2291
@baank, thanks for the latest update. Good news, we're getting down to the
nit-picks:
1. I had a checkstyle error running the full build with contrib check on
nifi-aws-service-api `UnusedImports: Unused import -
com.amazonaws.services.s3.AmazonS3Encryption`.
2. In your services, some of the Property Descriptors are marked as
supporting expression language, but EL is not evaluated when extracting the
value of the property (like
`context.getProperty(KMS_CMK_ID).evaluateAttributeExpressions().getValue()` or
similar). We should either evaluate the expressions or not mark them as
supporting expression language:
* EncryptedS3ClientService (KMS_CMK_ID, SECRET_KEY, PRIVATE_KEY,
PUBLIC_KEY)
* EncryptedS3PutEnrichmentService (KMS_KEY_ID, CUSTOMER_KEY)
It's fine to update this PR. I'll work out rebasing and squashing when
we're ready.
---