[
https://issues.apache.org/jira/browse/NIFI-4642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269151#comment-16269151
]
ASF GitHub Bot commented on NIFI-4642:
--------------------------------------
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/2303
NIFI-4642 updated tests to be more tolerant/variable to different sys…
…tem speeds. Many of these should be integration tests and not unit tests
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-4642
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2303
----
----
> Unstable nifi core build due to validate process scheduler test
> ---------------------------------------------------------------
>
> Key: NIFI-4642
> URL: https://issues.apache.org/jira/browse/NIFI-4642
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Joseph Witt
> Assignee: Joseph Witt
> Fix For: 1.5.0
>
> Attachments:
> 0001-NIFI-4642-updated-tests-to-be-more-flexible-in-timin.patch
>
>
> Tests run: 16, Failures: 1, Errors: 0, Skipped: 2, Time elapsed: 34.747 sec
> <<< FAILURE! - in org.apache.nifi.controller.scheduling.TestProcessorLifecycle
> validateProcessScheduledAfterAdministrativeDelayDueToTheOnScheduledException(org.apache.nifi.controller.scheduling.TestProcessorLifecycle)
> Time elapsed: 3.147 sec <<< FAILURE!
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.nifi.controller.scheduling.TestProcessorLifecycle.validateProcessScheduledAfterAdministrativeDelayDueToTheOnScheduledException(TestProcessorLifecycle.java:372)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
