[
https://issues.apache.org/jira/browse/MINIFICPP-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274559#comment-16274559
]
ASF GitHub Bot commented on MINIFICPP-49:
-----------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/188#discussion_r154381712
--- Diff: libminifi/CMakeLists.txt ---
@@ -74,6 +74,7 @@ target_link_libraries(core-minifi ${UUID_LIBRARIES}
${JSONCPP_LIB} yaml-cpp )
find_package(ZLIB REQUIRED)
include_directories(${ZLIB_INCLUDE_DIRS})
+target_link_libraries(core-minifi minifi-expression-language-extensions)
--- End diff --
Should be able to use enable_if to to completely eliminate the code and the
function calls, but I'm not terribly worried. Cost will be low and can be
changed in the future.
It won't be completely optimized. With -O3 you'll get a stack setup, checks
for the std::__throw_bad_function_call() and delete in the assembler. It's not
the same as calling an empty function that does nothing, which can be optimized
out, but in my opinion it's premature to concern ourselves over the cost.
> NiFi Expression Language support
> --------------------------------
>
> Key: MINIFICPP-49
> URL: https://issues.apache.org/jira/browse/MINIFICPP-49
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Jeremy Dyer
> Assignee: Andrew Christianson
>
> An implementation of NiFi's expression language is needed for the cpp version
> of the project. The feature should support all of the same EL syntax that
> NiFi supports so that any flow developed in NiFi and then ran through the
> minifi-toolkit will generate a valid .yml configuration file. Currently if
> there are any expression language values in the flow.yml file the agent will
> not act as anticipated or crash.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
