[
https://issues.apache.org/jira/browse/NIFI-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278929#comment-16278929
]
ASF GitHub Bot commented on NIFI-4661:
--------------------------------------
GitHub user joewitt opened a pull request:
https://github.com/apache/nifi/pull/2318
NIFI-4661 no longer building and including the gprc elements by default
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joewitt/incubator-nifi NIFI-4661
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2318.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2318
----
commit 8e5e2ebbd2b5b95d1bb411c69a61b241970c348a
Author: joewitt <[email protected]>
Date: 2017-12-05T17:41:16Z
NIFI-4661 no longer building and including the gprc elements by default
----
> The nifi-grpc-bundle is built using externally access binaries which create
> build portability problems
> ------------------------------------------------------------------------------------------------------
>
> Key: NIFI-4661
> URL: https://issues.apache.org/jira/browse/NIFI-4661
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions, Tools and Build
> Reporter: Joseph Witt
> Assignee: Joseph Witt
> Fix For: 1.5.0
>
>
> It has been reported that nifi builds on powerpc environments were failing
> due to the nifi-grpc-bundle not being able to build in that environment. It
> turns out is because the grpc processors use some plugins that access some os
> specific binaries outside the normal process and for grpc it is not supported
> yet in the powerpc environment. No problem so we exclude them for that
> environment.
> Then, in upgrading to more recent versions of the plugin and grpc libraries
> the build stopped working in Centos6 environments because the grpc protocol
> buffers build plugin (protoc) requires GLIBC_2.14 or newer and Centos6 has
> GLIBC_2.12.
> Given the os and environment specific nature of this component I plan to move
> inclusion of building this module and inclusion of the nar to requiring
> explicit profile activation.
> If this PR is merged I will update the website/release build instructions to
> talk about this specifically so that it is included in the normal releases.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
