[GitHub] nifi-minifi-cpp pull request #212: MINIFICPP-12: Resolve warnings found duri...

[apiri]

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/212#discussion_r155021318
  
    --- Diff: CMakeLists.txt ---
    @@ -138,18 +145,18 @@ if (NOT DISABLE_LIBARCHIVE)
     endif()
     
     option(ENABLE_GPS "Enables the GPS extension." OFF)
    -if (ENABLE_GPS)
    +if (ENABLE_ALL OR ENABLE_GPS)
    --- End diff --
    
    would be good to highlight the ENABLE_ALL in the building section of our 
README


---