[
https://issues.apache.org/jira/browse/MINIFICPP-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278998#comment-16278998
]
ASF GitHub Bot commented on MINIFICPP-12:
-----------------------------------------
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/212#discussion_r155021318
--- Diff: CMakeLists.txt ---
@@ -138,18 +145,18 @@ if (NOT DISABLE_LIBARCHIVE)
endif()
option(ENABLE_GPS "Enables the GPS extension." OFF)
-if (ENABLE_GPS)
+if (ENABLE_ALL OR ENABLE_GPS)
--- End diff --
would be good to highlight the ENABLE_ALL in the building section of our
README
> Enable -Wall when building
> --------------------------
>
> Key: MINIFICPP-12
> URL: https://issues.apache.org/jira/browse/MINIFICPP-12
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: marco polo
> Assignee: marco polo
> Priority: Minor
> Labels: Durability, Reliability
> Fix For: 0.4.0
>
>
> Implement -Wall and correct any or omit any issues.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
