[
https://issues.apache.org/jira/browse/NIFI-4672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280337#comment-16280337
]
ASF GitHub Bot commented on NIFI-4672:
--------------------------------------
GitHub user apiri opened a pull request:
https://github.com/apache/nifi/pull/2322
NIFI-4672 Adding missing quotes around arguments passed in from the e…
…ntrypoint script.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [-] Have you written or updated unit tests to verify your changes?
- [-] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [-] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [-] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/incubator-nifi nifi-4672
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2322
----
commit 60d0e5cd2051ada4901b2840ce705f123161def8
Author: Aldrin Piri <[email protected]>
Date: 2017-12-06T15:45:51Z
NIFI-4672 Adding missing quotes around arguments passed in from the
entrypoint script.
----
> NiFi toolkit is not properly passing arguments to the underlying script
> -----------------------------------------------------------------------
>
> Key: NIFI-4672
> URL: https://issues.apache.org/jira/browse/NIFI-4672
> Project: Apache NiFi
> Issue Type: Bug
> Components: Docker
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
>
> If I perform a Docker run of the resulting NiFi toolkit image as an
> executable, there are inconsistencies in how the argument is passed to the
> underlying scripts.
> Consider the following where I am using the Docker image to generate
> certificates:
> {code}
> docker run --rm -it \
> -v /tmp/certs:/tmp/certs \
> apache/nifi-toolkit \
> tls-toolkit \
> standalone \
> -C "CN=Random User, OU=NiFi, O=Apache, C=US" \
> -n localhost \
> -o /tmp/certs
> {code}
> This will result in an incorrect client DN of just CN=Random being created.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
