[
https://issues.apache.org/jira/browse/NIFI-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283955#comment-16283955
]
ASF GitHub Bot commented on NIFI-4562:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2331
NIFI-4562: If an Exception is thrown when merging FlowFiles, ensure t…
…hat we remove the 'bundle' flowfile before exiting the method
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-4562
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2331
----
commit b8d94f4bec8fdac78ebc65553a01b57b142fac09
Author: Mark Payne <[email protected]>
Date: 2017-12-08T18:09:00Z
NIFI-4562: If an Exception is thrown when merging FlowFiles, ensure that we
remove the 'bundle' flowfile before exiting the method
----
> MergeContent errors with FlowFileHandlingException: transfer relationship not
> specified if IOException thrown
> -------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-4562
> URL: https://issues.apache.org/jira/browse/NIFI-4562
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.5.0
>
> Attachments: NIFI-4562.xml
>
>
> If an IOException is thrown when merging FlowFiles (for instance out of disk
> space or too many open files), it will be converted to a ProcessException,
> and BinFiles will catch that. It will then transfer FlowFiles to 'failure'
> and call session.commit(). However, if a 'merged' FlowFile already was
> created then it does not get removed. As a result, the call to session.commit
> will throw a FlowFileHandlingException indicating that the FlowFile's
> transfer relationship is not set.
> We need to make sure that each of the 'mergers' catches this ProcessException
> and removes the created 'bundled' flowfile before re-throwing it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
