Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2295#discussion_r156244644
  
    --- Diff: 
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoTest.java
 ---
    @@ -37,47 +29,24 @@
     import org.junit.Ignore;
     import org.junit.Test;
     
    -import com.google.common.collect.Lists;
    -import com.mongodb.MongoClient;
    -import com.mongodb.MongoClientURI;
    -import com.mongodb.client.MongoCollection;
    -
    -@Ignore("Integration tests that cause failures in some environments. 
Require that they be run from Maven to run the embedded mongo maven plugin. 
Maven Plugin also fails in my CentOS 7 environment.")
    -public class PutMongoTest {
    -    private static final String MONGO_URI = "mongodb://localhost";
    -    private static final String DATABASE_NAME = 
PutMongoTest.class.getSimpleName().toLowerCase();
    -    private static final String COLLECTION_NAME = "test";
    -
    -    private static final List<Document> DOCUMENTS = Lists.newArrayList(
    -        new Document("_id", "doc_1").append("a", 1).append("b", 
2).append("c", 3),
    -        new Document("_id", "doc_2").append("a", 1).append("b", 
2).append("c", 4),
    -        new Document("_id", "doc_3").append("a", 1).append("b", 3)
    -        );
    +import java.util.Collection;
    +import java.util.HashSet;
    +import java.util.Iterator;
    +import java.util.List;
     
    -    private TestRunner runner;
    -    private MongoClient mongoClient;
    -    private MongoCollection<Document> collection;
    +import static com.google.common.base.Charsets.UTF_8;
    --- End diff --
    
    This doesn't look necessary, and even so we should be using 
StandardCharsets unless there's some reason not to.


---

Reply via email to