[
https://issues.apache.org/jira/browse/NIFI-4644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289912#comment-16289912
]
ASF GitHub Bot commented on NIFI-4644:
--------------------------------------
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2304
@MikeThomsen thanks for the 'bump'. I did think about it quite a bit and
decided that all does appear to be okay. But to be honest, I had forgotten to
merge. Sorry about that! Did some verifications manually just now and am happy
with all that I'm seeing, using LookupRecord with the IP Enrichment lookup
service and the SimpleKeyValueLookup Service. Thanks for the update and for
hanging in there, even when I dropped the ball on the review :)
> LookupService should support more than String,String key value pairs
> --------------------------------------------------------------------
>
> Key: NIFI-4644
> URL: https://issues.apache.org/jira/browse/NIFI-4644
> Project: Apache NiFi
> Issue Type: Bug
> Reporter: Mike Thomsen
> Assignee: Mike Thomsen
>
> The current interface is:
> {code:java}
> T lookup(Map<String, String> coordinates)
> {code}
> Limiting that to String, String has already caused problems for people using
> the MongoDBLookupService. For example, a user wanting to do a lookup using a
> String/Integer combination will find that the type is converted to
> String/String automatically and it will fail against any data source that
> cannot automatically make that conversion.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
