[
https://issues.apache.org/jira/browse/NIFI-4694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290236#comment-16290236
]
ASF GitHub Bot commented on NIFI-4694:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/2338
NIFI-4694: Make PutSFTP Disable Directory Listing a normal property
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4694
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2338.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2338
----
commit bce2ada3ddd7cd03b6ef447cdcaaddcb520201a9
Author: Koji Kawamura <[email protected]>
Date: 2017-12-14T02:22:41Z
NIFI-4694: Make PutSFTP Disable Directory Listing a normal property
----
> Make PutSFTP 'Disable Directory Listing' a normal property
> ----------------------------------------------------------
>
> Key: NIFI-4694
> URL: https://issues.apache.org/jira/browse/NIFI-4694
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
> Priority: Minor
>
> PutSFTP checks dir existence and if not, it tries to create the dir. Since
> it's done by these two operations, if any other SFTP client (other thread,
> other NiFi node in the same cluster or whatever) created the same dir between
> checking and creating dir, it's possible to get an Exception.
> Actually, above error can be avoided, by a dynamic property named 'Disable
> Directory Listing'. If set to 'true', then the processor won't perform
> directory existence check. It will just perform create dir operation blindly
> and swallow an Exception if thrown.
> The property has been a dynamic property, but it should be a normal property
> so that users can notice the option.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
