[
https://issues.apache.org/jira/browse/NIFI-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291777#comment-16291777
]
ASF GitHub Bot commented on NIFI-4696:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2342
NIFI-4696: Add Flowfile attribute EL support and per-table concurrency to
PutHiveStreaming
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4696
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2342.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2342
----
commit 9f53a0d729b39e7f332ebd76abf09e5d4ffea83f
Author: Matthew Burgess <[email protected]>
Date: 2017-12-14T22:19:25Z
NIFI-4696: Add Flowfile attribute EL support and per-table concurrency to
PutHiveStreaming
----
> Support concurrent tasks in PutHiveStreaming
> --------------------------------------------
>
> Key: NIFI-4696
> URL: https://issues.apache.org/jira/browse/NIFI-4696
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Matt Burgess
> Assignee: Matt Burgess
>
> Currently PutHiveStreaming (PHS) can only support a single task at a time.
> Before NIFI-4342, that meant each target table would need its own PHS
> instance, which can be cumbersome with large numbers of tables. After
> NIFI-4342, Expression Language could be used for SDLC purposes
> (database/table changes between development and production, e.g.).
> However it would be nice to be able to support at least database/table names
> using flow file attributes, and also to support multiple tasks to handle them
> concurrently. Due to the nature of PHS and the Streaming Ingest APIs (and
> implementation), it is likely not prudent to allow two tasks to write to the
> same table and partition at the same time.
> I propose adding flow file attribute EL evaluation where prudent, and
> allowing per-table concurrency in PHS. A thread will attempt to get a lock on
> a table, and if it cannot, will rollback and return.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
