Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2335#discussion_r157257088
--- Diff:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/provenance/StandardAnalysisContext.java
---
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.atlas.provenance;
+
+import org.apache.nifi.atlas.NiFiFlow;
+import org.apache.nifi.atlas.resolver.ClusterResolver;
+import org.apache.nifi.authorization.user.NiFiUser;
+import org.apache.nifi.controller.status.ConnectionStatus;
+import org.apache.nifi.provenance.ProvenanceEventRecord;
+import org.apache.nifi.provenance.ProvenanceRepository;
+import org.apache.nifi.provenance.lineage.ComputeLineageResult;
+import org.apache.nifi.provenance.lineage.ComputeLineageSubmission;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.Collections;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+
+public class StandardAnalysisContext implements AnalysisContext {
+
+ private final Logger logger =
LoggerFactory.getLogger(StandardAnalysisContext.class);
+ private final NiFiFlow nifiFlow;
+ private final ClusterResolver clusterResolver;
+ private final ProvenanceRepository provenanceRepository;
+
+ public StandardAnalysisContext(NiFiFlow nifiFlow, ClusterResolver
clusterResolver,
+ ProvenanceRepository
provenanceRepository) {
+ this.nifiFlow = nifiFlow;
+ this.clusterResolver = clusterResolver;
+ this.provenanceRepository = provenanceRepository;
+ }
+
+ @Override
+ public List<ConnectionStatus> findConnectionTo(String componentId) {
+ return nifiFlow.getIncomingRelationShips(componentId);
+ }
+
+ @Override
+ public List<ConnectionStatus> findConnectionFrom(String componentId) {
+ return nifiFlow.getOutgoingRelationShips(componentId);
+ }
+
+ @Override
+ public String getNiFiClusterName() {
+ return nifiFlow.getClusterName();
+ }
+
+ @Override
+ public ClusterResolver getClusterResolver() {
+ return clusterResolver;
+ }
+
+ private ComputeLineageResult getLineageResult(long eventId,
ComputeLineageSubmission submission) {
+ final ComputeLineageResult result = submission.getResult();
+ try {
+ if (result.awaitCompletion(10, TimeUnit.SECONDS)) {
+ return result;
+ }
+ logger.warn("Lineage query for {} timed out.", new
Object[]{eventId});
+ } catch (InterruptedException e) {
+ logger.warn("Lineage query for {} was interrupted due to {}.",
new Object[]{eventId, e}, e);
+ } finally {
+ submission.cancel();
+ }
+
+ return null;
+ }
+
+ @Override
+ public ComputeLineageResult queryLineage(long eventId) {
+ final ComputeLineageSubmission submission =
provenanceRepository.submitLineageComputation(eventId, NIFI_USER);
+ return getLineageResult(eventId, submission);
+ }
+
+ public ComputeLineageResult findParents(long eventId) {
+ final ComputeLineageSubmission submission =
provenanceRepository.submitExpandParents(eventId, NIFI_USER);
+ return getLineageResult(eventId, submission);
+ }
+
+ // NOTE: This user is required to avoid NullPointerException at
PersistentProvenanceRepository.submitLineageComputation
+ private static final QueryNiFiUser NIFI_USER = new QueryNiFiUser();
--- End diff --
@ijokarumawak I think I understand now what is going on. In a secured
environment, you would indeed get back all UNKNOWN event types, because that
user would not be authorized to see the events. But even the UNKNOWN event
would include the ID of the event. It looks like you're not actually using the
other info from the lineage but rather just using the Event ID to lookup the
actual Event (doing so without a user). So all of this seems to me now :) Sorry
about all of the confusion - and thanks for the clarifications!
---
