[ 
https://issues.apache.org/jira/browse/NIFI-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296798#comment-16296798
 ] 

ASF GitHub Bot commented on NIFI-4707:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2351#discussion_r157756243
  
    --- Diff: 
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/reporting/ReportLineageToAtlas.java
 ---
    @@ -640,7 +640,7 @@ private void 
consumeNiFiProvenanceEvents(ReportingContext context, NiFiFlow nifi
             final AnalysisContext analysisContext = new 
StandardAnalysisContext(nifiFlow, clusterResolvers,
                     // FIXME: This class cast shouldn't be necessary to query 
lineage. Possible refactor target in next major update.
                     
(ProvenanceRepository)eventAccess.getProvenanceRepository());
    -        consumer.consumeEvents(eventAccess, context.getStateManager(), 
events -> {
    +        consumer.consumeEvents(null, eventAccess, 
context.getStateManager(), events -> {
    --- End diff --
    
    Agreed, I will update


> SiteToSiteProvenanceReportingTask not returning correct metadata
> ----------------------------------------------------------------
>
>                 Key: NIFI-4707
>                 URL: https://issues.apache.org/jira/browse/NIFI-4707
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>
> When the SiteToSiteProvenanceReportingTask emits flow files, some of them 
> include a "componentName" field and some do not. Investigation shows that 
> only the components (except connections) in the root process group have that 
> field populated. Having this information can be very helpful to the user, 
> even though the names might be duplicated, there would be a mapping between a 
> component's ID and its name. At the very least the behavior (i.e. component 
> name being available) should be consistent.
> Having a full map (by traversing the entire flow) also opens up the ability 
> to include Process Group information for the various components. The 
> reporting task could include the parent Process Group identifier and/or name, 
> with perhaps a special ID for the root PG's "parent", such as "@ROOT@" or 
> something unique.
> This could also allow for a PG ID in the list of filtered "component IDs", 
> where any provenance event for a processor in a particular PG could be 
> included in a filter when that PG's ID is in the filter list.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to