Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2351
Hi @mattyb149 Thanks for updating this PR. It mostly looks good, however,
while I was testing, I found few points those can be improved. I went ahead and
added following improvements on top ob your commits. Would you cherry-pick this
commit?
https://github.com/ijokarumawak/nifi/commit/8effe3b19681ac34594a2f33e9d049ef081730a6
1. "Remote Input/Output Port" port name and process group id can only be
retrieved by mapping ConnectionStatus source or destination component id.
2. When a ProcessGroupId is used to filter events, the filtering should
consider PG hierarchy, meaning if PG1 is a child of Root, and PG2 is a child of
PG1, and PG1 uuid is used as filter component id, then provenance events
happening at PG2 should also be reported.
Other minor improvements:
- Simplified consumeEvents method signature
- Refactored ComponentMapHolder methods visibility
- Renamed componentMap to componentNameMap
- Throw an exception when the reporting task fails to send provenance
data to keep current provenance event index so that events can be consumed again
Thank you!
---
