GitHub user phrocker opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/223

    MINIFICPP-351: Remove civet 3rd party dir and rocksdb shared lib, gtest, 
and tools

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-351

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #223
    
----
commit f86a38799d995fba5c0178df0f662b6a2ed7cb88
Author: Marc Parisi <phrocker@...>
Date:   2017-12-20T17:40:46Z

    MINIFICPP-351: Remove Civetweb third party directory

commit 24201d5b971f223b03233a24e9376b00e4595b59
Author: Marc Parisi <phrocker@...>
Date:   2017-12-20T18:00:42Z

    MINIFICPP-351: Remove rocksdb tools, gtest, and shared lib

----


---

Reply via email to