[
https://issues.apache.org/jira/browse/NIFI-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299581#comment-16299581
]
ASF GitHub Bot commented on NIFI-4714:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/2355
NIFI-4714: Use lowercase hostname for validation.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-4714
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2355
----
commit a624cf1ec0096df5e8f7c2801df01f32fa9560c9
Author: Koji Kawamura <ijokarumawak@...>
Date: 2017-12-21T05:11:14Z
NIFI-4714: Use lowercase hostname for validation.
----
> S2S does not work with default configuration if hostname has uppercase
> ----------------------------------------------------------------------
>
> Key: NIFI-4714
> URL: https://issues.apache.org/jira/browse/NIFI-4714
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.5.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
> Fix For: 1.5.0
>
>
> NIFI-4632 added hostname retrieved by InetAddress.getLocalHost() to valid
> hostnames. But it does not lowercase the hostname while hostHeaderIsValid
> method matches lowercased hostname against valid hosts. This makes S2S with
> default configuration to fail if hostname contains uppercase character.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
