[ 
https://issues.apache.org/jira/browse/NIFI-4717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301487#comment-16301487
 ] 

ASF GitHub Bot commented on NIFI-4717:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/2359

    NIFI-4717: [More Testing Needed] Several minor bug fixes and performance 
improvements aroun…

    …d record-oriented processors
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-4717

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2359.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2359
    
----
commit 57a5a09fe91dce191fc459745dfa343f1578ee85
Author: Mark Payne <markap14@...>
Date:   2017-12-21T17:31:32Z

    NIFI-4717: Several minor bug fixes and performance improvements around 
record-oriented processors

----


> Minor bugs and performance improvements to record-oriented processors
> ---------------------------------------------------------------------
>
>                 Key: NIFI-4717
>                 URL: https://issues.apache.org/jira/browse/NIFI-4717
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>
> While testing some corner cases, I have run into a few minor issues with some 
> of the record oriented processors/libraries:
> ConvertRecord performs very poorly if the writer is the JSON RestSetWriter 
> and configured to write the schema using the avro.schema attribute.
> If QueryRecord fails to parse data properly with the configured reader, it 
> may roll back the session instead of routing to failure, leading the FlowFile 
> being stuck on the queue. This includes an error message indicating that the 
> FlowFile has an active callback or input stream that hasn't been closed.
> QueryRecord fails if referencing a field that is of UNION type.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to