[
https://issues.apache.org/jira/browse/NIFI-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302188#comment-16302188
]
ASF GitHub Bot commented on NIFI-4323:
--------------------------------------
GitHub user jtstorck opened a pull request:
https://github.com/apache/nifi/pull/2360
NIFI-4323 Wrapped Get/ListHDFS hadoop operations in ugi.doAs calls
NIFI-3472 Removed explicit relogin code from HDFS/Hive/HBase components and
updated SecurityUtils.loginKerberos to use UGI.loginUserFromKeytab. This brings
those components in line with daemon-process-style usage, made possible by
NiFi's InstanceClassloader isolation. Relogin (on ticket expiry/connection
failure) can now be properly handled by hadoop-client code implicitly.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jtstorck/nifi NIFI-4323
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2360.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2360
----
commit 760de56ad0dc61aeaacec797dff270c304059b64
Author: Jeff Storck <jtswork@...>
Date: 2017-12-23T03:53:59Z
NIFI-4323 Wrapped Get/ListHDFS hadoop operations in ugi.doAs calls
NIFI-3472 Removed explicit relogin code from HDFS/Hive/HBase components and
updated SecurityUtils.loginKerberos to use UGI.loginUserFromKeytab. This brings
those components in line with daemon-process-style usage, made possible by
NiFi's InstanceClassloader isolation. Relogin (on ticket expiry/connection
failure) can now be properly handled by hadoop-client code implicitly.
----
> Get/List/DeleteHDFS processors should use UGI.doAs when invoking HDFS
> operations
> --------------------------------------------------------------------------------
>
> Key: NIFI-4323
> URL: https://issues.apache.org/jira/browse/NIFI-4323
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.3.0
> Reporter: Jeff Storck
> Assignee: Jeff Storck
>
> While the Get/List/DeleteHDFS processors are working without wrapping HDFS
> operations in UGI.doAs calls, for best practice, those operations should be
> performed as PrivilegedExceptionActions supplied to the UGI.doAs method.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
