[ 
https://issues.apache.org/jira/browse/NIFIREG-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308388#comment-16308388
 ] 

ASF GitHub Bot commented on NIFIREG-81:
---------------------------------------

Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/2219
  
    @bbende @mcgilman - I just did few tests with latest changes and I want to 
confirm this is the expected behaviour: if versioning a process groups with 
defined variables that are used in processors of the PG, then updating the 
values of the variables won't be considered as a change.
    
    I do understand/agree that this is the expected behaviour: it is a way to 
provide a generic flow that is configurable through variables and everyone can 
instantiate the flow and update the variables for their own use case. Then, as 
@JPercivall suggested, when importing a PG, it could be nice to have a dialog 
window with all the variables included in the process group that need to be 
configured (NIFIREG-81).
    
    However if the flow evolves and variables are added/deleted, this is not 
considered as a change. I'm a bit worried about this if it's not clearly 
documented. Let's say in v1, I have a variable that is defined at versioned PG 
level, and then, at v2, I removed the variable at PG level because I want to 
use an environment variable. When updating to v2 in another environment, the 
user will have to remember that the variable needs to be manually removed even 
though the environment variable has been defined because the PG variable will 
overide the environment variable.
    
    I think that deleting/adding variables should be considered as a change for 
the versioning. Thoughts? (this could totally be addressed in a separate JIRA)


> Variable Registry properties that are expected for a versioned Flow should be 
> tracked 
> --------------------------------------------------------------------------------------
>
>                 Key: NIFIREG-81
>                 URL: https://issues.apache.org/jira/browse/NIFIREG-81
>             Project: NiFi Registry
>          Issue Type: Improvement
>    Affects Versions: 0.1.0
>            Reporter: Joseph Percivall
>
> As a user, pulling down a new versioned flow, I'd like to know which 
> properties are expected in my NiFi's Variable Registry to run the flow. By 
> explicitly calling these out I can more easily configure and understand the 
> flow on deployment. Also, would facilitate maintainability. 
> An easy example of a typical flow that would utilize this is one that relies 
> on an external source which is configured per environment (SSL file paths, 
> Web service URL, etc.).
> This could also pave the way to set "default" variables within a Registry 
> instance and elsewhere.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to