[ 
https://issues.apache.org/jira/browse/NIFI-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310834#comment-16310834
 ] 

ASF GitHub Bot commented on NIFI-4734:
--------------------------------------

GitHub user joewitt opened a pull request:

    https://github.com/apache/nifi/pull/2369

    NIFI-4734 refactored couchbase bundle, jms bundle, removed jms test-l…

    …ib usage, fixed broken SeeAlso and service links causing docs warns. 
Corrected L&N in each bundle.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joewitt/incubator-nifi NIFI-4734

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2369.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2369
    
----
commit 5cc9989e8cfdd862e39e7433cfc7dd09bd128bf8
Author: joewitt <joewitt@...>
Date:   2018-01-04T03:11:01Z

    NIFI-4734 refactored couchbase bundle, jms bundle, removed jms test-lib 
usage, fixed broken SeeAlso and service links causing docs warns. Corrected L&N 
in each bundle.

----


> Resolving remaining warnings at startup due to poor classloader isolation 
> practices in some older bundles and remove JMS test-lib source
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-4734
>                 URL: https://issues.apache.org/jira/browse/NIFI-4734
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions, Flow Versioning
>            Reporter: Joseph Witt
>            Assignee: Joseph Witt
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> {quote}
> 2018-01-03 00:21:37,448 WARN [main] org.apache.nifi.nar.ExtensionManager 
> Component org.apache.nifi.processors.couchbase.GetCouchbaseKey is bundled
> with its referenced Controller Service APIs 
> org.apache.nifi.couchbase.CouchbaseClusterControllerService. The service APIs 
> should not be bundled wit
> h component implementations that reference it.
> 2018-01-03 00:21:37,452 WARN [main] org.apache.nifi.nar.ExtensionManager 
> Component org.apache.nifi.processors.couchbase.PutCouchbaseKey is bundled
> with its referenced Controller Service APIs 
> org.apache.nifi.couchbase.CouchbaseClusterControllerService. The service APIs 
> should not be bundled wit
> h component implementations that reference it.
> 2018-01-03 00:21:37,454 WARN [main] org.apache.nifi.nar.ExtensionManager 
> Controller Service org.apache.nifi.couchbase.CouchbaseClusterService is bu
> ndled with its supporting APIs 
> org.apache.nifi.couchbase.CouchbaseClusterControllerService. The service APIs 
> should not be bundled with the impleme
> ntations.
> 2018-01-03 00:21:39,887 WARN [main] org.apache.nifi.nar.ExtensionManager 
> Controller Service org.apache.nifi.jms.cf.JMSConnectionFactoryProvider is
> bundled with its supporting APIs 
> org.apache.nifi.jms.cf.JMSConnectionFactoryProviderDefinition. The service 
> APIs should not be bundled with the imp
> lementations.
> 2018-01-03 00:21:41,012 WARN [main] o.a.n.d.html.HtmlDocumentationWriter 
> Could not link to org.apache.nifi.couchbase.CouchbaseClusterControllerServ
> ice because no bundles were found
> 2018-01-03 00:21:41,049 WARN [main] o.a.n.d.html.HtmlDocumentationWriter 
> Could not link to org.apache.nifi.ssl.RestrictedStandardSSLContextService
> because no bundles were found
> 2018-01-03 00:21:41,094 WARN [main] o.a.n.d.html.HtmlDocumentationWriter 
> Could not link to org.apache.nifi.couchbase.CouchbaseClusterControllerServ
> ice because no bundles were found
> 2018-01-03 00:21:41,172 WARN [main] o.a.n.d.html.HtmlDocumentationWriter 
> Could not link to org.apache.nifi.distributed.cache.server.map.Distributed
> MapCacheClient because no bundles were found
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to