[
https://issues.apache.org/jira/browse/NIFI-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311909#comment-16311909
]
ASF GitHub Bot commented on NIFI-4738:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2373
NIFI-4738: Fixed logic bug in JdbcCommon for 9-digit unsigned ints
I tested this with MEDIUMINT UNSIGNED, MEDIUMINT, and INT(9) UNSIGNED
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4738
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2373.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2373
----
commit 9f2ec30f48efbf794884b7b5988b7bf265252904
Author: Matthew Burgess <mattyb149@...>
Date: 2018-01-04T19:30:47Z
NIFI-4738: Fixed logic bug in JdbcCommon for 9-digit unsigned ints
----
> ExecuteSQL error when table uses 9-digit unsigned int
> -----------------------------------------------------
>
> Key: NIFI-4738
> URL: https://issues.apache.org/jira/browse/NIFI-4738
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
>
> There is a logic bug in the fix for NIFI-3076 that causes unsigned 9-digit
> integers to be treated as ints when the DB (at least MySQL) will return a
> Long object. Although the fix for NIFI-3076 does work for MEDIUMINT, this is
> because the logic bug is not exposed when the MEDIUMINT is signed (as it
> satisfies the other condition of the if clause). But if a field is declared
> as INT(9) UNSIGNED, the logic will see if the precision is 9 digits or less,
> and treat it as an Integer if so. But an unsigned value with 9 digits will
> fit in a Long, and should be treated as such in the schema.
> Recommended fix is to replace the "<= MAX_DIGITS_PER_INT" with "<
> MAX_DIGITS_PER_INT".
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
