[ 
https://issues.apache.org/jira/browse/NIFI-4726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317665#comment-16317665
 ] 

ASF GitHub Bot commented on NIFI-4726:
--------------------------------------

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2363#discussion_r160315696
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/JsonUtilsPool.java
 ---
    @@ -0,0 +1,87 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.standard.util;
    +
    +import com.bazaarvoice.jolt.JsonUtil;
    +import com.bazaarvoice.jolt.JsonUtilImpl;
    +import org.apache.commons.pool.PoolableObjectFactory;
    +import org.apache.commons.pool.impl.GenericObjectPool;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +public class JsonUtilsPool {
    +    private final static Logger LOG = 
LoggerFactory.getLogger(JsonUtilsPool.class);
    +    static private GenericObjectPool pool;
    --- End diff --
    
    dont believe we would want a static pool instance.  We can just make the 
pool a member of the processor.


> Concurrency issue with JoltTransformJson
> ----------------------------------------
>
>                 Key: NIFI-4726
>                 URL: https://issues.apache.org/jira/browse/NIFI-4726
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Marco Gaido
>            Assignee: Marco Gaido
>             Fix For: 1.5.0
>
>
> JoltTransformJson uses under the hood Jackson to parse JSONs. On heavy 
> multithreading workloads, Jackson can have concurrency problem, as also 
> described in this Stackoverflow thread 
> https://stackoverflow.com/questions/17924865/jsonmappingexception-was-java-lang-arrayindexoutofboundsexception.
>  This can cause all the parsing to fail when this problem occurs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to