[ 
https://issues.apache.org/jira/browse/MINIFICPP-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318512#comment-16318512
 ] 

ASF GitHub Bot commented on MINIFICPP-359:
------------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/231#discussion_r160422690
  
    --- Diff: libminifi/include/core/yaml/YamlConfiguration.h ---
    @@ -245,11 +245,11 @@ class YamlConfiguration : public FlowConfiguration {
        *
        * @param yamlNode a pointer to the YAML::Node that will be checked for 
the
        *                   presence of an idField
    -   * @param idField  the string of the name of the idField to check for. 
This
    +   * @param field  the string of the name of the idField to check for. This
        *                   is optional and defaults to 'id'
        * @return         the parsed or generated UUID string
        */
    -  std::string getOrGenerateId(YAML::Node *yamlNode, const std::string 
&idField = "id");
    +  std::string getOrGenerateField(YAML::Node *yamlNode, const std::string 
&field = "id");
    --- End diff --
    
    End goal is outlined in 
https://issues.apache.org/jira/browse/MINIFICPP-359. getOrGenerateField is used 
in this PR for name now, not just id: `std::string name = 
getOrGenerateField(&connectionNode, "name");`


> Support anonymous connections in config.yml
> -------------------------------------------
>
>                 Key: MINIFICPP-359
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-359
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>            Priority: Minor
>
> Since connections are rarely, if ever, referenced by name or ID in a typical 
> config.yml, allow for anonymous (no ID and no name) connections. MiNiFi will 
> generate IDs for anonymous connections. This will make writing config.yml a 
> little simpler.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to