Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r160460513
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveQL.java
---
@@ -232,6 +233,13 @@ private FunctionContext(boolean rollbackOnFailure,
Charset charset, String state
getLogger().warn("Failed to parse hiveQL: {} due
to {}", new Object[]{hiveQL, e}, e);
}
+ try {
+ // set query timeout
+
stmt.setQueryTimeout(context.getProperty(QUERY_TIMEOUT).evaluateAttributeExpressions(flowFile).asInteger());
--- End diff --
Unfortunately asInteger() will throw a NumberFormatException if the EL
evaluates to a blank string/null. Should we warn that we're defaulting to zero,
or keep the current behavior which is an exception and rollback, perhaps adding
another logging statement to clarify the one that will follow (NFE for input
string "") ?
---
