Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2287#discussion_r160842851
  
    --- Diff: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java
 ---
    @@ -129,6 +130,12 @@
                 .defaultValue("100")
                 .expressionLanguageSupported(true)
                 .build();
    +    
    +    public static final PropertyDescriptor VERSION_ATTRIBUTE = new 
PropertyDescriptor.Builder()
    +                   .name("Version").displayName("Version Attribute")
    +                   .description("The name of the attribute containing the 
version for each FlowFile. Only used for index operation. Forces External 
Versioning")
    +                   
.required(false).expressionLanguageSupported(false).addValidator(StandardValidators.ATTRIBUTE_KEY_VALIDATOR)
    --- End diff --
    
    Well, the Identifier Attribute property is the way people have been using 
IDs, so making this change now would be a bit too invasive IMO. I think since 
the Versioning is new we can do it for that, but please keep the Identifier 
Attribute the same and we will make the appropriate change for NiFi 2.0 (please 
feel free to file a Jira). I apologize for my short-sightedness on the latter, 
but I don't think we can absorb that kind of breaking change on a minor release.


---

Reply via email to