[ 
https://issues.apache.org/jira/browse/NIFI-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323489#comment-16323489
 ] 

ASF GitHub Bot commented on NIFI-4768:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2397#discussion_r161132714
  
    --- Diff: 
nifi-nar-bundles/nifi-extension-utils/nifi-reporting-utils/src/main/java/org/apache/nifi/reporting/util/provenance/ProvenanceEventConsumer.java
 ---
    @@ -256,9 +297,15 @@ private boolean isFilteringEnabled() {
                             }
                         }
                     }
    +                if (!eventTypesExclude.isEmpty() && 
eventTypesExclude.contains(provenanceEventRecord.getEventType())) {
    +                    continue;
    --- End diff --
    
    These two, `eventTypesExclude` and `eventTypes` are the most 
computationally cheap conditions. So, these should be done at the beginning, 
before checking ProcessGroup hierarchies. How do you think?


> Add exclusion filters to SiteToSiteProvenanceReportingTask
> ----------------------------------------------------------
>
>                 Key: NIFI-4768
>                 URL: https://issues.apache.org/jira/browse/NIFI-4768
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>
> Although the SiteToSiteProvenanceReportingTask has filters for which events, 
> components, etc. to capture, it is an inclusive filter, meaning if a filter 
> is set, only those entities' events will be sent. However it would be useful 
> to also have an exclusionary filter, in order to capture all events except a 
> few. 
> One particular use case is a sub-flow that processes provenance events, where 
> the user would not want to process provenance events generated by components 
> involved in the provenance-handling flow itself. In this fashion, for 
> example, if the sub-flow is in a process group (PG), then the user could 
> exclude the PG and the Input Port sending events to it, thereby allowing the 
> sub-flow to process all other events except those involved with the 
> provenance-handling flow itself.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to