[
https://issues.apache.org/jira/browse/NIFI-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16324387#comment-16324387
]
ASF GitHub Bot commented on NIFI-4390:
--------------------------------------
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2157#discussion_r161299941
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/modal/jquery.modal.js
---
@@ -127,6 +128,10 @@
// check if the button should be disabled
if (isDisabled()) {
button.addClass('disabled-button');
+ // remove keyup listener
+ if (isDefinedAndNotNull(buttonConfig.handler) &&
isDefinedAndNotNull(buttonConfig.handler.keyup) && typeof
buttonConfig.handler.keyup === 'function') {
+ document.removeEventListener('keyup',
buttonConfig.handler.keyup, true);
--- End diff --
Is there a reason we're not using jQuery for adding/removing the event
listeners? This isn't a big deal but I'd prefer to remain consistent with the
rest of the code base if possible. Does it have to do with the useCapture flag
you've specified here?
> Add a keyboard shortcut for Connection related dialogs
> ------------------------------------------------------
>
> Key: NIFI-4390
> URL: https://issues.apache.org/jira/browse/NIFI-4390
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core UI
> Reporter: Yuri
> Priority: Minor
> Labels: dialogs, shortcuts, ui, ux
> Attachments: nifi_dialogs_v1.ods
>
>
> Current dialogs don't allow to bound a keyboard shortcut to an action. This
> hinders the UX, since there are many dialogs involved in the most common
> interactions.
> For instance, adding a new connection with a single relationship still
> requires a click at the confirm button. Instead, it should be possible to
> confirm the dialog simply by hitting the Enter key.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
