[
https://issues.apache.org/jira/browse/NIFI-4745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326701#comment-16326701
]
ASF GitHub Bot commented on NIFI-4745:
--------------------------------------
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2384
Hi @martin-mucha Thanks for your first contribution! The PR is closed
without being reviewed and I can't find other PRs created for NIFI-4745. Do you
have a PR ready for being reviewed somewhere?
About your concern to add another argument to the completeFlowFile method
which has already lots of arguments, I think that should be fine, since it's
just a private method and the method is a good place to add new attribute
values.
BTW, ValidateRecord can validate multiple Records within a single incoming
FlowFile. Is it going to be sufficient to write validation result to a FlowFile
attribute? Isn't it be more useful if we can write validation failure detail to
the outgoing Records, so that each record can have its failure detail?
> Emit validation failure description in attribute from ValidateRecord processor
> ------------------------------------------------------------------------------
>
> Key: NIFI-4745
> URL: https://issues.apache.org/jira/browse/NIFI-4745
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.5.0
> Reporter: Martin Mucha
> Priority: Minor
>
> We need to pass description of validation failure further in
> processing chain, and eventually pass it back to calling system.
> Therefore having failure description logged in logs and issued as provenance
> route event is not sufficient for us.
> It should be easy to emit same data, which are being sent in provenance route
> event, from ValidateRecord as new attribute.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
